webclient - column picker missing options

[Christine Burns]

Circulation Library
Circulation Modifier

These two options are missing from the column picker in the Checkout, Check in & Holds interfaces. I think these are useful options that should be included on these screens.

[Andrea Neiman (aneiman)]

Confirmed 2.12

[[e-mail] (tji)]

Other places need these two columns: Items Out, Bills.

[Cesar V (cesardv)]

Added a fix for these fields. (Note that circ_lib shows up with label "Checkout/Renewal Library" in ItemsOut)

Did a sort of 2-in-1 (branch-wise) fix for this one and bug 1685933 which wanted to add Owning Library to ItemsOut/Checkout.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1661685_circmod_and_circlibrary_columns_missing_from_grid

[Jason Etheridge (phasefx)]

marked as 1685933 as a duplicated, consolidating everything here

[Jason Etheridge (phasefx)]

we may want to go ahead and add a fix for circ modifier in Item Status with these; is there a separate bug for that?

[Jason Etheridge (phasefx)]

circ modifier looks good in check out, items out, bills, and check in

broken in Item Status list view, but not by this patch

circ lib looks good in check out, bills, and check in, but I'm not seeing it in items out

broken in Item Status list view

owning lib looks good in check out and items out, but I'm not seeing it in bills and check in

shows up as an id in Item Status list view

in detail view it has the wrong value, and appears to be duplicating the circ lib

[Cesar V (cesardv)]

Jason, for the ItemsOut view, the circ lib is populated there, but it's labeled "Checkout / Renewal Library"
IIRC the grid there is using it that way.

As far as circ modifier column in Item Status, I couldn't find a bug report for that, but I suppose we could append that to this patch/bug, or create a new one if that something we want to do.

[Jason Etheridge (phasefx)]

For consistency, I think we should make sure all instances of circ.circ_lib are labelled as "Checkout/Renewal Library", and reserve "Circulation Library" for copy.circ_lib.

[Jason Etheridge (phasefx)]

The patches as written look good to me; I'm okay pushing them to master if desired, or we could wait and supplement them fixes for what I listed above. I'll try to push a quick branch to address those, along with my sign-offs.

[Jason Etheridge (phasefx)]

Bills interface needs Checkout/Renewal Library column for circs and Billing Location for groceries.

[Kathy Lussier (klussier)]

+1 to Jason's labeling recommendations.

[Jason Etheridge (phasefx)]

branch in progress, contains sign offs for Cesar's patches and...

commit 3cd74588c3559bca76d20d6e4813e5420e854ef3
Author: Jason Etheridge <email address hidden>
Date: Wed Jun 28 14:41:53 2017 -0400

    lp1661685 fieldmapper label change for circ

    Change "Circulation Library" to "Checkout / Renewal Library"

    Signed-off-by: Jason Etheridge <email address hidden>

commit a9c7e0d6495c821d938d59da0d4c7053b4366af2
Author: Jason Etheridge <email address hidden>
Date: Wed Jun 28 14:40:02 2017 -0400

    lp1661685 webstaff: add money.grocery to pcrud

    and add a single column called Location to the Bills interface which shows
    either the circ.circ_lib or the grocery.billing_location for a given xact

    and the specific columns for both xact types

    Signed-off-by: Jason Etheridge <email address hidden>

[Jason Etheridge (phasefx)]

commit 2b9c7d099783f3a4288b7e325f381ca59ec8ed6c
Author: Jason Etheridge <email address hidden>
Date: Wed Jun 28 14:58:37 2017 -0400

    lp1661685 webstaff: Fix Owning Lib in Item Status

    Detail View

    Signed-off-by: Jason Etheridge <email address hidden>

[Jason Etheridge (phasefx)]

rebased against master, with one more commit adding Circ Lib to Items out:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/webstaff-bugs2

[Jason Etheridge (phasefx)]

commit eaefb73ab32c9a79b9ba86c1e41113b99869a443
Author: Jason Etheridge <email address hidden>
Date: Mon Jul 3 13:47:25 2017 -0400

    lp1661685 fix circ lib in patron holds list

    and make it and the circ modifier column hidden by default

    Signed-off-by: Jason Etheridge <email address hidden>

[Andrea Neiman (aneiman)]

I have tested this code and consent to signing off with my name, Andrea Neiman and my email address, <email address hidden>

[Jason Etheridge (phasefx)]

Thanks Andrea, Cesar! Pushed to master