Comment 20 for bug 1659181

Thanks Kyle!

As mentioned in IRC, the branch needs some cleaning up. When I cherry-picked http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=0910392cdaf5fb7eaf1c8cf4c74c33533fd0e288 , I still encounterd several of the same problems described above. When I merged the branch, I had to resolve some conflicts, but I was finally able to get the Damaged Items dialog to appear (hooray!).

However, the commits will need to be picked before merging, so I want to make sure I'm picking everything that's required. I thought that there may be a commit I was missing further down in the branch, but I didn't see anything when I performed git cherry.

Now that I have the popup, I have two issues to report:

1. When marking the item damaged while it is still checked out to the patron, the item remains on the patron's Items Out list. This differs from the xul client's behavior where the item was checked in as part of the marking damaged process. This occurs regardless of the state of the 'Charge item price when marked damage' setting.

2. I love that we eliminated one modal here. However, I find the 'charge fees' and 'no charge' buttons confusing. Using the 'no charge' button before clicking submit works as expected, and no charge is assessed to the user. However, I think staff may be confused because the price of the item still remains in the charge box. Maybe it would be better if clicking 'no charge' added visual reinforcement by changing the price to 0. Clicking 'Charge Fees', then, could reinstate the price of the item in that box.

IMO, #1 should be addressed before merging the code and #2 could be addressed in a new bug once we have the basic functionality in place.

Many thanks for all of your work on this Kyle!