Comment 19 for bug 1659181

Revision history for this message
Kyle Huckins (khuckins) wrote :

I've made a few commits since my last message, and have just squashed and pushed them up - the code itself should be good to go as is now. Some modifications have been made - the cause of the error you were running into was due to some of the introduced code trying(and mostly succeeding) to handle something already handled in the API. Problem being it was accounting for one of the charge settings, but not both of them. That code has been reworked to allow the API to do its thing unhindered. Additionally, the mark damaged modal has been simplified, and no longer calls up the patron billing modal to change a value(yay less modals!).

Branch continues to be found here: http://git.evergreen-ils.org?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1659181-item-damaged-prompt

A couple things I've noticed:

1. The Patron Billing interface doesn't seem to display bill notes properly - in some cases it does, but on full details and the regular patron bills interface, there doesn't seem to be any sign of manually entered notes, despite the notes displaying in the DB.

2. A suggestion from Bill Erickson was that there are a number of places in cat/item/app.js where "egItem" is imported, but referred to as itemSvc, which was pretty confusing to go through for the both of us.