Alt pull list breaks with the chunking/bundling change in OpenSRF 2.5

Bug #1657885 reported by Mike Rylander
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

When chunking was renamed bundling and actually chunking added in OpenSRF 2.5, the few places in Evergreen that tried to make use of the old mechanism directly now break. The most obvious breakage is in the alternate printable hold pull list. A forthcoming branch addresses this by testing for the presence of the new regime and acts accordingly.

Tags: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :
tags: added: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

To test the above:

 1) In Evergreen 2.11 running on top of OpenSRF 2.5+ (master, currently), attempt to use the alt pull list printing interface at a location with many holds on their pull list. The progress bar will spin forever.

 2) After applying this patch, do the same. The interface should work quickly.

Revision history for this message
Kathy Lussier (klussier) wrote :

Mike,

Is this entirely fix bug 1642054? I wasn't sure since that bug targets OpenSRF as well.

Revision history for this message
Mike Rylander (mrylander) wrote :

This is the full fix. OpenSRF isn't changing, this just makes Evergreen aware of changes in OpenSRF 2.5+ so EG can be used atop it.

Revision history for this message
Mike Rylander (mrylander) wrote :

Because it's directly related to the initial fix in this bug, there's a new commit on the branch to help out Vandelay. From the commit message:

There is a naive attempt to force immediate streaming of results in Vandelay
for certain processes, but it both only helps a little, and breaks under the
new OpenSRF bundling/chunking logic. So, we'll drop it where it's not
directly configurable, and test for the appropriate features where we can.

Revision history for this message
Mike Rylander (mrylander) wrote :

I've added another update to bring back the vandelay spool processing update behavior for OpenSRF 2.4 and earlier. All versions should act the same way now.

Revision history for this message
Kathy Lussier (klussier) wrote :

Thanks Mike! I added a signoff and merged to master and release 2.11.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.