Comment 10 for bug 1645862

Revision history for this message
Terran McCanna (tmccanna) wrote :

Okay, now that I understand how it's supposed to work, I like the way it is going. A few comments:

- It definitely needs release notes.
- The Save Grid Settings to Org option only appears on Angular grids (even though there are org unit settings available for the AngularJS grids). I think that can just be clarified in the release notes.
- I think having a new perm just for this functionality might be safer than using the UPDATE_ORG_UNIT_SETTING_ALL perm.
- It would be nice if the the Save Grid Settings to Org option only appeared to users who actually have the perm.
- The org unit selector that pops up when clicking on the Save Grid Settings to Org option allows the selection of any org unit regardless of whether or not the user has perms to save at that level. If the user saves at a level they do not have access to, the failure is silent - a failure message would improve the usability here.
- The Library Settings interface makes it look as if you should be able to edit the saved settings from there, but you cannot, it just gives you: [object Object]