Comment 4 for bug 1635737

Revision history for this message
Galen Charlton (gmc) wrote :

I've looked through other uses of OpenSRF::Utils::interval_to_seconds, and a number of them (such as booking elbow room, fine intervals, grace periods, auto renewal intervals, and the like) where typical values are not likely to be long enough for the difference between "30 days" and "1 month" to matter. However, there's one other case where, for the sake of consistency, I think it would be good to extend this patch: calculating due dates for non-catalogued items.

Also, I think it would be worth reaching out to open-ils-general to give people a heads up about the potential change and ask for feedback; while I imagine it wouldn't be a huge deal, I know of at least one consortium that has loan durations that are multiples of a month.