Comment 13 for bug 1635386

Revision history for this message
Kyle Huckins (khuckins) wrote :

I've amended all my commits - this should function as expected. Any community feedback on this would be appreciated, there's one portion that I'm not 100% sure on - I'm checking to see if the item is checked out by making sure circulation.stop_fines isn't set to CHECKIN, and checking to see if circulation.due_date exists.

Now what it needs is the glyphicon support - for some reason it hasn't been behaving as I'd expect it to with the code in place. While it *should* work, it doesn't seem to be displaying the glyphicon. I've attempted moving it over into a function and calling that through ngClass, but no luck.

To summarize the above comments, this adds a fairly sizeable but necessary feature: egGrid now has an optional parameter rowclass. rowclass works by passing through an object containing a function, rowClass(item). This function will apply specified classes based on logic relating to the item passed in. An example of usage(and the primary functionality of this issue) is in bills.js $scope.colorizeBillsList.

Dumping all this information here to see if there's any feedback regarding this approach, if it seems sane or if there's something I'm overlooking