Comment 17 for bug 1629078

Revision history for this message
Linda Jansova (skolkova-s) wrote :

Also, when looking more in depth into how strings are localized, I have discovered that there are cases with "l" missing, e.g.:

<eg-grid-field label="[% ('First Name') %]" path='first_given_name' visible sortable multisortable></eg-grid-field>

(taken from http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/templates/staff/circ/patron/t_search_results.tt2 - it is then used to generate /eg/staff/circ/patron/search)

Besides the "l" thing - is the path='first_given_name' surely correct? I mean when looking at a variety of other templates it appears that double quotes are a bit more common than single quotes used in this example and a handful of others.

On the contrary, it seems that localized strings should be enclosed in single quotes and there are cases when double quotes are used instead (http://git.evergreen-ils.org/?p=Evergreen.git&a=search&h=HEAD&st=grep&s=%5B%25+l%28%22).