Comment 1 for bug 1618136

Jeff Godin (jgodin) wrote :

When examining the file referenced in the test failure, we find that it is not valid Javascript, and the problem seems to be with SQL query strings being included, newlines and all.

Changes to the IDL in commit 91f844b introduced a requirement for additional pre-processing of the IDL before fm_IDL2js.xml can be expected to generate output that is valid Javascript.

OpenILS::WWW::IDL2js was modified to perform this pre-processing, but there is one other stock consumer of fm_IDL2js.xsl at present:

Open-ILS/web/js/ui/default/staff/test/data/ is used to generate IDL2js.js which is then used in webstaff tests.

The working branch at user/jeff/lp1618136_fix_webstaff_test_failures includes a proposed fix: simply add the pre-processing steps from OpenILS::WWW::IDL2js to the test support script;a=shortlog;h=refs/heads/user/jeff/lp1618136_fix_webstaff_test_failures