Comment 21 for bug 1562061

I also did some testing of this code, and I like the idea that it makes Lost and Long Overdue billings exclusive, so that the patron can only be billed once.

Some observations about when a Long Overdue item is marked Lost:

- As Dan said, the billings are not touched.

- The row in action.circulation does not change in any way. The stop_fines retains the value LONGOVERDUE.

- The copy fields: editor, edit_date, status, and status_changed_time all get updated as the Lost status is assigned to the copy.

This all makes good sense and leaves a clear trail to help in understanding the history of the transaction.

Unfortunately, I found problems with the ou settings that dictate how to handle Lost/Long Overdue billings should the long-overdue-marked-lost item be checked in:

circ.void_lost_on_checkin - Void lost item billing when returned
circ.void_longoverdue_on_checkin - Void Long-Overdue Item Billing When Returned

Even with both of these set to TRUE (as we have in our consortium), the billing for the long-overdue-marked-lost item will not be voided. The status is Lost, but there is no Lost billing to void since the Long Overdue billing remains.

Perhaps combining the mirrored settings related to voiding billings we currently have for Long Overdue and Lost could solve this problem - and have the added benefit of shaving off a few YAOUS's.

Thanks for your work on this, Dan. I would love it if we could get this to a state where we could put it in production.