Comment 5 for bug 1552409

Revision history for this message
Blake GH (bmagic) wrote :

Thomas,

This code is confirmed working in Opera, Firefox, Chrome, OSX Safari.
I like the idea of just implementing the whole thing in TT. I utilized the perl module to set some variables to make the code easier to understand in TT. However, I believe all of those uri regular expressions could be moved out of the perl module and put into the Template Toolkit. The login form contains a blurb at the top when the authentication prompt was caused by the attempt to access. I already put some regex in TT to inject the title of the resource into the URL for user clarity.

I also like the idea of the hidden url which is only revealed after login (and therefore not publicly visible.). That had crossed my mind. That would require some perl additions? The URL of the desired 856$u would still need to be changed to the generic OPAC link which would take the browser through the login, then redirect to the secret url which is supported by a template file of the same name. The external URL would need to live through all of that. If we are going to make changes to EGCatLoader.pm for secret url reasons then we might as well leave those two functions and keep the smaller TT changes?