Comment 10 for bug 1552409

Dan,

2. It's been a long time since I worked on this code, but a memory is coming to me. I checked into the encoding and I believe that the URL is conveyed to the template toolkit encoded. bre.marc has the urls htmlentitized. Perhaps the template toolkit still needs to convert it to htmlentities. If so, where is the function? Do we have a ready-made function in TT2? This touches on the topic: http://www.template-toolkit.org/docs/manual/Directives.html

3. It may not be clear, but the redirect only works when the 856$u is crafted in the MARC. This patch assumes that the library is replacing the 856$u. Example:
/(.*)/\/eg\/opac\/referringurl?intendedurl=$1
In other words, prefixing the URL with "/eg/opac/referringurl?intendedurl="
Therefore, only MARC that has been imported or otherwise altered will receive this login prompt when clicked.

4. I don't come up with the best of names while in development. I am open to anything.

5. You're right, in order to work properly, the destination URL needs to be https, which is enforced in the code, so the library doesn't need to worry about that. They do need to understand that the external vendor needs to accept the connection over SSL. Shame on vendors who are not using SSL when delivering electronic resources.