Comment 17 for bug 1519055

Revision history for this message
Ben Shum (bshum) wrote :

Some minor formatting tidbits for next time, Jake.

1) Try to keep the first line as a subject line, and keep a break between that and the next lines for larger paragraph description. For some interfaces, the extra break is important to avoid odd display interactions. So that's just my own personal pet peeve.

2) Try to add the LP# to every commit in the series, so that they remain linked together. This way, we know the work was all related to each other.

3) Remember to add your signed-off-by line to every commit you make, not just the ones that formally are part of new changes. This signifies the commit is to be shared/included.

Other than that, no big deal, I made the minor edits to the structure as best I could. Alternatively in the future, you can always squash fixups and changes into the same published commit to make it easier for reviewers to grab and apply your changeset. I know that developers differ on opinion and practice on this, but I find that when publishing work, it's a cleaner, more polished look to squash away unnecessary changesets.

Pushed to master for 2.10-beta.