Typo in self-check checkout receipt action trigger template

Bug #1517232 reported by Josh Stompro on 2015-11-17
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

EG 2.8.4

I just noticed that there is a typo in the web based/native self check template for checkout receipts.

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/950.data.seed-values.sql;hb=HEAD#l8765

    <div>[% lib_addr.city %], [% lib_addr.state %] [% lb_addr.post_code %]</div>

'lb_addr.post_code' should be 'lib_addr.post_code'

Would cause the zip code to not show.

Josh

Michele Morgan (mmorgan) wrote :

Adding a link to another seed data typo bug:

https://bugs.launchpad.net/evergreen/+bug/1519911

tags: added: selfcheck
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Terran McCanna (tmccanna) wrote :

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=f1a893f6d03bd2e63e7cd10261e4a816fd8b21d7

This corrects typos in the see data for these action trigger templates:
- Self-Checkout Receipt
- Hold Cancelled (No Target) Email Notification
- Hold Cancelled (No Target) User Message

Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Terran McCanna (tmccanna) wrote :

*seed data*

tags: added: pullrequest
Terran McCanna (tmccanna) wrote :

PS - I only did an update to the 950.data.seed-values.sql here - should I include separate individual upgrade scripts too? They are such tiny changes, I wasn't sure that anybody would need them.

I think it would be nice to do a regexp_replace to fix these issues in the database for existing installs. I don't know if that is an acceptable practice though. If an org was already using the event, and already fixed the typo, then it should have no effect.

It might be a surprise if someone is using the selfcheck receipts, and the zip code starts showing up now. But I don't know if that would be considered good or bad.

Josh

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers