Comment 18 for bug 1501781

Revision history for this message
Mike Rylander (mrylander) wrote :

This is looking good!

One comment/issue: historically, we try not to schema-qualify stuff coming from extensions into any of our own. It's happening here due to a side effect of us setting the search_path to (at least) evergreen, but I would be more comfortable if the extension (and all others we use in the future, as well) was explicitly loaded in the public schema and then we just didn't qualify the unaccent() call. That would fit with how we deal with things like ts_rankcd and friends, avoids mixing "our" code with "their" code, and helps avoid a situation where more than one version of an extension is loaded and the wrong one is used due to differing use of schema qualification.

Thoughts? Or am I just being paranoid.