I'd like to see this get into 3.1. Mike, are you still working on this?
I looked over the code, and it generally seems sound, and it isn't obvious what's causing Jason's issues. Here are two quick thoughts:
1) One possible "crack" I see for data to fall through is the dead map selector. The "AND cn.label = '##URI##' AND NOT cn.deleted" seems overly restrictive. Now, I realize we *shouldn't* have mappings to deleted or non-##URI## call numbers, but it isn't impossible, and I don't think we'd have harm in leaving those restrictions out. If a map isn't used, let's get rid of it regardless, I think.
2) (side note) orphaned_uri_list doesn't seems to be used any more, so should be removed.
Any branch that reduces data churn is good in my book. Thanks, all!
I'd like to see this get into 3.1. Mike, are you still working on this?
I looked over the code, and it generally seems sound, and it isn't obvious what's causing Jason's issues. Here are two quick thoughts:
1) One possible "crack" I see for data to fall through is the dead map selector. The "AND cn.label = '##URI##' AND NOT cn.deleted" seems overly restrictive. Now, I realize we *shouldn't* have mappings to deleted or non-##URI## call numbers, but it isn't impossible, and I don't think we'd have harm in leaving those restrictions out. If a map isn't used, let's get rid of it regardless, I think.
2) (side note) orphaned_uri_list doesn't seems to be used any more, so should be removed.
Any branch that reduces data churn is good in my book. Thanks, all!