Placing holds fails unintuitively when preferred pickup location is disabled via org unit setting opac.holds.org_unit_not_pickup_lib

[Michele Morgan]

If a user has set a preferred pickup location, and that pickup location is disabled via the org unit setting opac.holds.org_unit_not_pickup_lib, the user can attempt to place a hold and their preferred pickup location is filled in automatically. Upon clicking "Submit", however, the form refreshes with no indication what the error is.

If the user opens the pickup location dropdown, their preferred pickup location is greyed out and cannot be chosen.

Here's a screencast:

http://screencast.com/t/I4YzNY5o

An error message stating that the patron's preferred pickup location is currently unavailable with instructions to choose another would eliminate confusion in this situation, and also avoid system behavior that appears broken.

[Kathy Lussier (klussier)]

Just adding a note that the same behavior occurs for org units that do not have the "can have users" flag enabled. If we provide a message for the situation that Michele described, we should see the same message for those org units that can't have users. I'm not sure how often my scenario would happen in practice, other than for the admin user, but I thought I would just throw it out there as another spot where we could use this message.

[Dale Rigney (drigney)]

The hold screen preferred pickup location is filled in automatically with the value of the opac.default_pickup_location user setting. If the patron does not have an opac.default_pickup_location user setting the preferred pickup location is filled in automatically with the patron's Home Library. If that home library has the opac.holds.org_unit_not_pickup_lib setting set to true the same silent failure happens.

[Joan Kranich (jkranich)]

Evergreen Release 3.2.10
Browsers Chrome and Firefox

Confirming that I can recreate the situations described by Michele and Dale, comment #2.

[Jennifer Bruch (jbruchpails)]

This has been coming up for PaILS/SPARK libraries as they close for COVID exposures and want to divert patrons elsewhere in a system.

[Terran McCanna (tmccanna)]

Note that this is still an issue in 3.6.1 Bootstrap OPAC

[Michele Morgan (mmorgan)]

Still an issue through 3.8.