This comment is interesting: "# XXX floating items still stick where they are even with no-op checkin?" It asks the question if copies should float on a no-op checkin.
I was going to make the no-op checkin code behave as the block above where floating is checked via the evergreen.can_float() database function. (In that case it would be handy to add a utility function so the code is in one place.) However, that comment makes me wonder if floating should be considered at all on a no-op checkin?
If no-op should not cause copies to float, then the fix for this bug is as simple as removing the else block for a no-op checkin. If the consensus is that copies should float on a no-op checkin, then we'll need to go through the evergreen.can_float function.
I'll start a branch to do the latter in the meantime.
This comment is interesting: "# XXX floating items still stick where they are even with no-op checkin?" It asks the question if copies should float on a no-op checkin.
I was going to make the no-op checkin code behave as the block above where floating is checked via the evergreen. can_float( ) database function. (In that case it would be handy to add a utility function so the code is in one place.) However, that comment makes me wonder if floating should be considered at all on a no-op checkin?
If no-op should not cause copies to float, then the fix for this bug is as simple as removing the else block for a no-op checkin. If the consensus is that copies should float on a no-op checkin, then we'll need to go through the evergreen.can_float function.
I'll start a branch to do the latter in the meantime.