Comment 35 for bug 1468422

Revision history for this message
Dan Wells (dbw2) wrote :

In thinking over this some more, a couple things worth noting before this gets pushed.

First, we didn't really follow through with the parameter renaming discussion in comments #17 - #19. I don't really have a preference, and am happy with how they are now, but didn't just want to gloss over it. One side effect benefit of making them different is that it discourages passing the whole parameter blob to auth_internal, which in some cases contains the the plaintext password, and we're better off not passing it around when we don't need to.

Second, I think we still need to shore up the log redaction config to cover some of these new methods, both in the sample config and in the release notes. That should be an easy task, and I'll plan on taking care of that late today if nobody beats me to it.