Hi Dan, I had a similar moment of confusion over that. As you noted, I opted simply to replicate the existing behavior.
However, I think it would make sense to mimic the PATRON_CARD_INACTIVE behavior and only return a PATRON_CARD_INACTIVE event if the password check succeeds. Otherwise, return the generic login-failed event. I'll take a look at that...
Hi Dan, I had a similar moment of confusion over that. As you noted, I opted simply to replicate the existing behavior.
However, I think it would make sense to mimic the PATRON_ CARD_INACTIVE behavior and only return a PATRON_ CARD_INACTIVE event if the password check succeeds. Otherwise, return the generic login-failed event. I'll take a look at that...