Comment 19 for bug 1468422

On Thu, Dec 3, 2015 at 9:59 AM, Bill Erickson <email address hidden> wrote:
> On Wed, Dec 2, 2015 at 5:58 PM, Dan Wells <email address hidden> wrote:
[snip]
>>
>> First, the easier ones. The current auth API uses 'type' and 'org' for
>> argument names, but the auth_internal code expects 'login_type' and
>> 'org_unit' for the same values. Should we consider keeping the names
>> the same instead? It's slightly more predictable, but if we are instead
>> trying to purposefully improve the names, I can see that side as well.
>> Just wanted to point it out and see what others felt.
>>
>
> My goal was to make the parameter names more explicit. Perhaps consistency
> is more clear, though. No strong opinions from me on that.
>

My preference would be to keep one set of names, and to use the
existing names. Parity seems more important than name-based
documentation, as I think future developers using those API calls will
likely cargo-cult the existing public-side code.

my $0.02...

-miker