Comment 24 for bug 1464709

Agreed is_targetable is an expansion of the scope of this bug. But so was changing checkout_ok to is_available to cover hold targeting and #available. The door has been opened..

Before any branches are merged, we have to update the working branch to set is_available=false for On Holds Shelf and tweak the checkout SQL to allow their checkout. Otherwise, On Holds Shelf items would be targetable and #available. I'll look at this today if I can.

For Reserves, are we confident no one is setting holdable=true for the Reserves status locally? (I would not expect it, but I really don't know) If they are, setting is_available=true would cause Reserves items to appear on the pull list, which would probably be unexpected. At minimum, the release notes would need to make this very obvious.

If we agree is_targetable would be a valuable addition, my preference would be to implement it as part of this bug and delay the feature if necessary, mainly because I see the existing code as a potential foot-gun. I'll help push it along either way, though.