I have pushed my signoff with 2 follow up commits to user/dyrcona/lp1411422_Copy_details_repeated_in_search_results_when_item_or_volume_moved_with_parts_attached in the working repo:
I decided not to implement the removal of a monograph part when the last copy is transferred because a) it turned out to be way more work then I have time and more work than I feel should go into this bug fix, and b) to do it correctly, i.e. like removing the last volume and bib, would require a new org. unit setting to allow sites to configure that behavior. For those reasons, I decided that looked more like a new feature than a bug fix.
Finally, I did not push this to master or the other repos because I am getting test failures with this branch applied. I do not think this branch is responsible for those failures, but because of the failures, I think another pair of eyes on this are warranted. Below is the output of prove on the perlmods/live_t directory:
I have pushed my signoff with 2 follow up commits to user/dyrcona/ lp1411422_ Copy_details_ repeated_ in_search_ results_ when_item_ or_volume_ moved_with_ parts_attached in the working repo:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dyrcona/ lp1411422_ Copy_details_ repeated_ in_search_ results_ when_item_ or_volume_ moved_with_ parts_attached
I decided not to implement the removal of a monograph part when the last copy is transferred because a) it turned out to be way more work then I have time and more work than I feel should go into this bug fix, and b) to do it correctly, i.e. like removing the last volume and bib, would require a new org. unit setting to allow sites to configure that behavior. For those reasons, I decided that looked more like a new feature than a bug fix.
Finally, I did not push this to master or the other repos because I am getting test failures with this branch applied. I do not think this branch is responsible for those failures, but because of the failures, I think another pair of eyes on this are warranted. Below is the output of prove on the perlmods/live_t directory:
est Summary Report src/perlmods/ live_t/ 09-lp1198465_ neg_balances. t (Wstat: 512 Tests: 133 Failed: 2) src/perlmods/ live_t/ 19-lp1306666- abort-transit- copy-status. t (Wstat: 1792 Tests: 26 Failed: 7) src/perlmods/ live_t/ 24-offline- all-assets. t (Wstat: 256 Tests: 1 Failed: 1)
-------------------
Open-ILS/
Failed tests: 76, 133
Non-zero exit status: 2
Open-ILS/
Failed tests: 15-17, 21-22, 24, 26
Non-zero exit status: 7
Open-ILS/
Failed test: 1
Non-zero exit status: 1
Files=29, Tests=636, 85 wallclock secs ( 0.20 usr 0.04 sys + 13.73 cusr 1.07 csys = 15.04 CPU)
Result: FAIL
NOTE: The above is after my commit to fix & rename the test added by this branch.