At the moment, the proposed open-ils.actor.user.flag_as_deleted will let you mark as deleted a user that has open billable transactions, which seems a bit risky. I think that the checks in really_delete_user() should be moved into their own routine, then used to guard both open-ils.actor.user.flag_as_deleted and open-ils.actor.user.delete.
At the moment, the proposed open-ils. actor.user. flag_as_ deleted will let you mark as deleted a user that has open billable transactions, which seems a bit risky. I think that the checks in really_ delete_ user() should be moved into their own routine, then used to guard both open-ils. actor.user. flag_as_ deleted and open-ils. actor.user. delete.