Comment 2 for bug 1353643

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Liam,

Just from looking at the code I have two suggestions.

It would be better if all of the upgrade scripts were squashed into one. The statements should all be inside one transaction.

It would also be useful if comments were added to give an indication of what the new database functions are meant to do and what the arguments mean/are for.

The changes do look interesting.

Cheers,
Jason