Comment 18 for bug 1350831

Revision history for this message
Mike Rylander (mrylander) wrote :

After my side quest I decided to step back, re-read the whole thread, and take another look at the situation globally.

First, I think we missed or lost sight of the fact that that this bug is a duplicate of bug 1308090, which already fixed the OP issue (though, looking at the code, I think it could be adjusted to protect the "Ph.D." case, and other dotted abbreviations. I will offer a branch to address that within the next few days.). I suspect that Blake does not have the fix from that bug in his installation if his current complaint is about trailing ISBD on author fields, which is what this bug is about. (If not, there needed to be a new LP bug anyway because his patch is confusing things.)

With the browse and browse-sort xpath (there since day-1 of browse) and existing normalizers (see bug 1308090), case differences are really the only remaining "duplicate" issue that can't be covered by the code as it stands today. I recommend that we mark this bug as a duplicate of 1308090, which the OP definitely was to begin with, and open a new LP bug to consider proper ways of ignoring case differences in display values for browse entries, because that's what's left, and is fixable without breaking browse generally.

IOW, I think too many (already addressed) wires are getting crossed on this bug now.

Objections to that?