Comment 11 for bug 1350831

Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks Elaine, I think we all agree that we want a better outcome for patrons.

However, there are and will continue to be browse entries that are provably not the "same thing" to end users, and should all exist and have different linked endpoints, and which have *different display values*, but also have *identical sort values*. The branch above won't allow those, and in fact will *collapse* all those different things into one entry, pretending they are the same.

I'll be as blunt as I possible can regading the patch offered, as a purely technical matter: it is a hammer looking for a nail, and only makes things worse for both users and code maintainer down the road. It shows a lack of understanding of the existing code, both in intent and extent, and it will drop valid, differentiated browse entries, decreasing user discovery.

If we simply want ISBD punctuation to be removed from the [end of] user-visible strings then we should do that, and we already have a way to do that without breaking anything else. I've pointed to where the mapping could be added to stock seed data, and if I can find time to come up with a good normalizer and mapping set for the stock data I will it, but regardless I'm going to continue to suggest we not add new landmines to trip over in the future.