View / Edit Existing Reports

Bug #1329503 reported by Bill Erickson on 2014-06-12
30
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

Here are some specs for supporting viewing the details of and editing reports:

http://yeti.esilibrary.com/dev/pub/techspecs/reports-view-edit-report.html

Targeting 2.7. I plan to get started on this soon.

Bill Erickson (berick) wrote :

Code pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1329503-view-edit-reports

This code depends on the code in bug #1332138. Install 1332138 first (once it's published), then install this working branch.

I *think* I tested all of the filter types to ensure they're values are properly populated, but I certainly could have missed one. Broader testing appreciated.

'pullrequest' tag pending bug #1332138

Changed in evergreen:
importance: Undecided → Wishlist
Bill Erickson (berick) wrote :

Bug #1332138 published. Adding pullrequest tag.

tags: added: pullrequest
Bill Erickson (berick) on 2014-08-04
Changed in evergreen:
assignee: Bill Erickson (erickson-esilibrary) → nobody
milestone: 2.next → 2.7.0-beta1
Bill Erickson (berick) wrote :

Working to squeeze in a few last bug fixes. Will update again shortly.

tags: removed: pullrequest
Bill Erickson (berick) wrote :

I've pushed a patch to fix a number of issues:

    * correctly propagate values for the "between" widget
    * propagate pivot data and label when present
    * propagate report run time
    * improvements to report email propagation

Bill Erickson (berick) wrote :

rebased and merged with bug #1332138 at:

working/user/berick/lp1332138-lp1329503-reports-combined

Kathy Lussier (klussier) wrote :

We've been testing this branch for a few days, and it's looking good. We still have a a very small issue with the run-time scheduling not always propagating correctly on the edited report, but I think this is something that can be addressed by full release time.

Signed off on the combined branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1332138-lp1329503-reports-combined

Ben Shum (bshum) wrote :

Pushed on up. Thanks Bill and Kathy.

Changed in evergreen:
status: New → Fix Committed
Bill Erickson (berick) wrote :

Two additional patches pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1329503-report-sched-repairs

These address issues with scheduling/recurrence and propagating sets of text values. I'll try to bug someone to merge these. If I get no takers, I'll toss them into a new bug.

Mike Rylander (mrylander) wrote :

Thanks, Bill. Fixes pushed to master.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers