Comment 8 for bug 1304462

Revision history for this message
Ben Shum (bshum) wrote :

I think I've narrowed down the potential source of the issue that Yamil is seeing. It seems that in results, we're looking to use pubinfo to display a combined statement about publication information. In record, it's broken out into its distinct parts -- pubpace, publisher, and pubdate. The issue is that the hunt for graphic_880s linking is not paying attention to the second indicator flag of any given 264. It seems to grab any one present, which is why Yamil can see a 264 with ind2=2 being used instead of the ind2=1 that we would expect.

Pertinent lines from misc_util.tt2:

args.pubinfo = "$args.pubplace $args.publisher $args.pubdate";

and later:

args.pubinfo = (args.pubinfos.size) ? args.pubinfos.0 : '';

So args.pubinfo is being defined once as the combined pubplace publisher and pubdate, but then defined again as the first in a group of pubinfos taken by looking for all the 260s and 264s in the hunt for linked graphic_880s.

I think what we should do to resolve this issue for search results would be to break it up similarly to how record details is done and have separate parts for pubplace, publisher, and pubdate to be displayed if there is something for publisher. Along the way, maybe we should enhance the results page to display distributor if that's what exists, etc. and get more meaningful 264 entries to display with the right label in search results.

Will try slapping some code together later.