Comment 5 for bug 1269574

Hello, I'm trying to understand what needs to be done to fix this.

open-ils.acq.lineitem_detail.cancel - Doesn't delete copies itself... maybe it should though?

open-ils.acq.lineitem.cancel - Calls the open-ils.acq.lineitem_detail.cancel function, and then deletes copies/volumes and bibs and holds as the next step.

Does the situation come up in real life where only some of the copies are canceled and others are not? In my limited experience I've only seen entire line items canceled, with all copies. It would be nice to just be able to use the open-ils.acq.lineitem.cancel which would handle removing the copies/volumes/bibs/holds.

If not, then the deleting copies, volumes, bibs and holds needs to move to open-ils.acq.lineitem_detail.cancel. It would only delete volumes, bibs, and holds if the current lineitem_detail is the last record for that volume/bib. This might fix some of the other situations where copies are not removed, if the problem is that in those cases just one lineitem_detail is being deleted.

Or maybe there is a better approach?

Josh