Evergreen

  1. Bug #1257910
  2. Comment #9

Comment 9 for bug 1257910

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

EG 3.11.1

We ran into another silent failure issue with the Check-in -> Mark Missing Pieces feature.
/eg/staff/circ/checkin/checkin

If the item checkout fails in the open-ils.circ.mark_item_missing_pieces because of a permission failure, the textcode is null, and errors out. A clue is a log message of "open-ils.circ.mark_item_missing_pieces: non-successful checkout"

https://gitlab.com/LARL/evergreen-larl/-/blob/77664b16c89e85473e265d786e0cc2de20b5111e/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm#L1672

Console error about textcode generated at
https://gitlab.com/LARL/evergreen-larl/-/blob/77664b16c89e85473e265d786e0cc2de20b5111e/Open-ILS/web/js/ui/default/staff/circ/services/item.js#L990

In our case, we had been adding a standing penalty to block further checkouts for those that have missing items... but forgot to give staff the ability to override the CIRC block.

Maybe a simple change would be to send up an alert dialog if evt.textcode is null, just so it is clear to the user that something caused the process to fail.