support user activity logging in safe authtoken generation

[Bill Erickson]

The safe authtoken generator, which is used for some 3rd-party services for verifying user accounts and (to date) accessing home library information does not currently log safe token access to the patron activity log.

Here is a patch to remedy that:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/safe-auth-activity-logging

In short, we store the user ID in the cache during safe token generation and later reference that ID in the safe token verification call to log a patron authentication "verify" action. Additionally, the verify call now accepts an optional user activity "who" string to specify the 3rd-party making the request.

[Ben Shum (bshum)]

Marking incomplete and removing pullrequest while this gets resubmitted with proper author signoff.

[Bill Erickson (berick)]

Rebased and pushed with sign-off:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1240119-safe-auth-act-logging

[Josh Stompro (u-launchpad-stompro-org)]

Should the API signature make note of the new optional param for this feature. Or is that only for required parameters?

Like:
@param safe_token Active safe token
@param who Optional user identifier string for logging.

Otherwise I tested this and it works just as described. I included a file with output from running through a session in srfsh and the logging output that shows the "who" param.

I have tested this code and consent to signing off on it with my
name,Josh Stompro and email address, <email address hidden>.

Josh

[Bill Erickson (berick)]

Rebased to current master. Added API comment about the new parameter. Added Josh's sign-off. (Thanks, Josh!). Squashed it back down to a nice tidy commit.

[Bill Erickson (berick)]

Pushed live test.

[Jason Stephenson (jstephenson)]

Thanks, everyone! Pushed to master, rel_2_8, and rel_2_7.