Mike, thanks for the review. I am sorry I didn't see your comment before I pushed the latest changes, but I think the approach I took in the last two commits is a decent middle ground for keeping the intended effect of 6205d9b43d60 while also honoring the search_field flag. It gets rid of search rows whenever search_field is false, but still preserves Dan's desire for searches like:
title:^Meditation
to work (when testing with the Concerto data set).
I know it seems like browse fields getting into search was an accidental feature in the first place, but it is useful, so until we have a more comprehensive solution, I am hoping what I have done here will suffice.
Mike, thanks for the review. I am sorry I didn't see your comment before I pushed the latest changes, but I think the approach I took in the last two commits is a decent middle ground for keeping the intended effect of 6205d9b43d60 while also honoring the search_field flag. It gets rid of search rows whenever search_field is false, but still preserves Dan's desire for searches like:
title:^Meditation
to work (when testing with the Concerto data set).
I know it seems like browse fields getting into search was an accidental feature in the first place, but it is useful, so until we have a more comprehensive solution, I am hoping what I have done here will suffice.