Comment 16 for bug 1235497

Pushed on two more commits to deal with the duplication. We are now up to eight commits.

But, the new fixes raise a new question. We currently add both a combined row and separate rows to metabib.xxxxxx_field_entry if a config.metabib_field entry has both search_field and browse_field set to true. Should we drop the combined row?

It looks simple to do, but I want some more eyes. For example, rather than inserting (as we do in recent releases):

  id | source | field | value
 756 | 17 | 5 | Concertos, trombone (1991) Meditation, trombone, orchestra Concertos, trombone (1976-77)
 755 | 17 | 5 | Concertos, trombone (1976-77)
 754 | 17 | 5 | Meditation, trombone, orchestra
 753 | 17 | 5 | Concertos, trombone (1991)

we would simply have:

  id | source | field | value |
 755 | 17 | 5 | Concertos, trombone (1976-77)
 754 | 17 | 5 | Meditation, trombone, orchestra
 753 | 17 | 5 | Concertos, trombone (1991)

That looks a lot better to me, and, again, I think would be simple to do. Thoughts?