Comment 18 for bug 1207533

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I failed to test this branch. I first tried a back port to 3.5 on a test vm that was mostly setup already, but the feature did nothing. I never saw the user's triggered events in the event log, even though I had two in the database.

I chalked that up to a problem with the back port and attempted to upgrade the VM and database to master so I could try again.

After deleting everything under /openils, updating prerequisites, installing OpenSRF and Evergreen fresh, updating the configuration files, clearing browser storage, etc., I was not able to login via the staff client. This could be a problem with anything and possibly not related to this branch. (Actually, I think I botched changing db settings in opensrf.xml.)

I moved on to another virtual machine running stock master. I installed a rebased version of this branch and pointed it at the database used in the previous test so that I would have production data to look at.

Once this was set up, I could login, retrieve the patron that had tow hold cancelled by staff messages added following the steps in comment #14 with two holds. When I go to look at the patron's triggered events, I see "Nothing to display" for both Circ and Holds. It could be that I'm not logged in at the same library that is listed as the "Creating Library" of the messages. It is the library in the "owner" field of the action_trigger.event_definition.

Given this behavior, I cannot say this code works. I also cannot say that it doesn't work.

The branch also has a conflict with Open-ILS/src/sql/Pg/950.data.seed-values.sql when rebased on master. It seems rather simple to fix, but this could warrant a needsrepatch tag.

I have run out of time to look at this for now, so I'm removing myself from the bug. Maybe someone else who has fewer hoops to jump through will have better luck testing this branch.