At least part of this doesn't pass my eyeball test:
'render' : function(my) {
var stat_obj = data.hash.ccs[ my.atc.copy_status()].name();
if (stat_obj.copy_active() == 't') return '';
var prop = 'staff.circ.utils.transit.copy_status_message';
return circStrings.getFormattedString(prop, [stat_obj.name()]);
}
In particular, the '.name()' in the initial assignment looks wrong, since stat_obj must be the "obj" for the rest of the code to work. Anyway, since I am focusing on review only for today, I am marking this incomplete, but will push a fix branch for the next round if nobody else does.
At least part of this doesn't pass my eyeball test:
'render' : function(my) { copy_status( )].name( ); copy_active( ) == 't') return ''; circ.utils. transit. copy_status_ message' ; getFormattedStr ing(prop, [stat_obj.name()]);
var stat_obj = data.hash.ccs[ my.atc.
if (stat_obj.
var prop = 'staff.
return circStrings.
}
In particular, the '.name()' in the initial assignment looks wrong, since stat_obj must be the "obj" for the rest of the code to work. Anyway, since I am focusing on review only for today, I am marking this incomplete, but will push a fix branch for the next round if nobody else does.