Comment 63 for bug 1198465

Sorry - I accidentally hit "Post" before I had barely gotten started on the last comment.

I tested the code again today, but I'm still finding problems with the "Lost Checkin Generates New Overdues" setting. I don't know if this was a problem introduced with the code merged to master earlier this week or if it only occurs with the negative balance branch. I would like to do some more testing next week without the negative balance branch loaded so that we can pin that down.

Here are my findings. I was working on a transaction similar to the one from above.

Relevant settings:
• Void overdue fines when item is marked lost - true
• Restore overdues on lost item return – true
• Lost checkin generates new overdues - true
• Prohibit negative balance (default) - true

The circ transaction below should have a max fine amount of $3

1. The patron had an item that accrued $2.40 in fines before being automatically set to lost on 11/14/13.
2. The fines were voided using the old method because it was done before the negative balance code was added.
3. A $20 lost fee was added to the patron's record.
4. A payment of $2.40 was applied to the record.
5. The lost item was checked in.

My expectation is that the user would now owe $.60 because a) the lost book fee has been adjusted b) the original $2.40 overdue fine should be covered by the cash payment and c) the user should only be charged another $.60 before hitting the max fine amount.

Instead, in addition to reinstating the original overdue fine of $2.40, which we expect, the system added new overdue fines from 11/15/14 through 1/14/14. The user is ultimately charged another $6.00 on the record.

Like I said, I plan to do more testing on this next week on a master system without the negative balance branch to see if this is problem in all of master now or if it's just a problem with this particular branch. I'll post my results as soon as I'm done.