Comment 12 for bug 1189989

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I pushed a branch based on Bill Ott's patch and fixed the internal server error. My branch is at:

working/user/dyrcona/lp1189989-Add-suspend-option-when-placing-hold

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1189989-Add-suspend-option-when-placing-hold

I did not address Galen's concern about the data parsing in #10 as he notes that almost identical code is used elsewhere when suspending a hold. (I believe it is used by the holds edit functionality of the My Account holds list.)

I believe my change addresses his issue with key injection.

I've tested my branch by placing a suspended hold and a not suspended hold using concerto data. In that limited context it works. I thinks this would make a good base to build off of.