This code seems to work well. I found things working sensibly in my tests, and I see that your unit tests all pass. Sure, there were some warnings in the output, but I think they're expected, e.g.
> No values found for existing caption subfield 'j', returning '*' (unknown value indicator) at
> /usr/local/share/perl/5.10.1/Test/More.pm line 1478
which makes sense to me.
I'll sign this off, but first I wondered if you had and preferences about how this will be squashed (or if you'll just squash it however you want)?
Hi Dan,
This code seems to work well. I found things working sensibly in my tests, and I see that your unit tests all pass. Sure, there were some warnings in the output, but I think they're expected, e.g.
> No values found for existing caption subfield 'j', returning '*' (unknown value indicator) at share/perl/ 5.10.1/ Test/More. pm line 1478
> /usr/local/
which makes sense to me.
I'll sign this off, but first I wondered if you had and preferences about how this will be squashed (or if you'll just squash it however you want)?
Thanks