Comment 13 for bug 1167541

In looking to see where this change in behavior was introduced, it seems to be a JSPAC vs TPAC difference.

I like the suggestion to use the workstation OU instead of the staff user's home_ou, and I don't see reason to keep the staff user's home_ou in the mix.

In the scenario where we are not overriding the default pickup library, I think that this order of preference works well:

* hold user's Default Pickup Library
* hold user's home_ou

In the case where we are overriding the default pickup library, I think that workstation OU should be sufficient.

An org unit setting to toggle the source of the default pickup library can determine if we override the user's defaults or not.

That org unit setting would toggle between the following two scenarios:

Configuration A (do not override user default pickup library for staff placed holds):

The default pickup library for staff-placed holds is the hold user's "default pickup library" user setting if set, otherwise the user's home_ou (which will always be set).

Configuration B (override user default pickup library for staff placed holds):

The default pickup library for staff-placed holds is the workstation OU, with belt-and-suspenders fallback to the two sources listed in Configuration A above.

For comparison, the current code implements what I'll call "Configuration X":

The default pickup library for staff-placed holds is the hold user's "default pickup library" user setting if set, otherwise the staff requestor's home_ou.

Some questions for interested parties while I work on a working branch:

Q1. Does anyone have a use case where an org unit setting is insufficient, and a workstation or a staff user setting would be desirable?

Q2. Does anyone object to removing staff user home_ou from consideration in favor of workstation OU?

Q3. Does anyone object to "Configuration X" above going away?

I won't wait for answers to these, but if you have a preference, please comment.