Comment 5 for bug 1164575

Revision history for this message
Dan Scott (denials) wrote :

I do have to say, though, maybe it's the early morning hours, but it seems like accepting a non-numeric value in a function called
jsonNumberToDBString might be applying a fix at the wrong point?

searchINPredicate seems to be applying the same tests as jsonNumberToDBString before going ahead and calling jsonNumberToDBString anyway; actually, these tests are duplicated several times throughout oils_sql.c. 7,000 lines of custom C code providing database access could probably stand a thorough re-examination on a regular basis :/

In any case, I haven't triggered the same problem again, so the fix seems to work for this case. Huzzah!