Hi Dan, actually, could you please create an upgrade script for your changes? Something along the lines of Open-ILS/src/sql/Pg/upgrade/XXXX.schema.lpad-number-repair.sql. See other files in the directory for examples. I'm happy to assist as needed.
If you're feeling adventurous, a few pgtap (Open-ILS/src/sql/Pg/t/*) tests for this function would be great, particularly since it's a small, easily tested function. This would also help demonstrate inputs and expected outputs for testers.
Hi Dan, actually, could you please create an upgrade script for your changes? Something along the lines of Open-ILS/ src/sql/ Pg/upgrade/ XXXX.schema. lpad-number- repair. sql. See other files in the directory for examples. I'm happy to assist as needed.
If you're feeling adventurous, a few pgtap (Open-ILS/ src/sql/ Pg/t/*) tests for this function would be great, particularly since it's a small, easily tested function. This would also help demonstrate inputs and expected outputs for testers.