Jason, my bad... I was rather confusion/ambiguous as to what branch I was intending to actually submit, and I think you might have tested this using the incorrect branch...
I just retested that branch and it seems to be working correctly for me... at this point though the branch itself is a little stale so I'm going to rebase with master and force push, so make it easier to test. Can you delete your local version of branch and repull and retest when you get the chance? Thanks!
Jason, my bad... I was rather confusion/ambiguous as to what branch I was intending to actually submit, and I think you might have tested this using the incorrect branch...
So the code for the alternative html5 version of the fix is not quite kosher, and I guess is still experimental since not all browsers support the "required" input attribute. (http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ cesardv/ hold_notify_ html5_formval)
Don't test/merge it...
The code I do what to do a PR on is the user/cesardv/ hold_notificati on_bugs (http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ cesardv/ hold_notificati on_bugs) branch, which fixed the issue using plain vanilla JS form validation.
I just retested that branch and it seems to be working correctly for me... at this point though the branch itself is a little stale so I'm going to rebase with master and force push, so make it easier to test. Can you delete your local version of branch and repull and retest when you get the chance? Thanks!