Clean up translatable strings in templates

Bug #1098189 reported by Pasi Kallinen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Several translatable strings in templates include html, newlines, or extraneous spaces, resulting in ugly and hard-to-translate strings in po-files.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/nohtmli18nstrings

That branch has several commits that clean up the strings.

Changed in evergreen:
status: New → Triaged
Revision history for this message
Pasi Kallinen (paxed) wrote :

As an example, here's some very messy translatable strings in po-files, before the cleanup:

---

msgid ""
"\n"
" <td>Page </td><td class=\"current_page\">%1</td><td> of </td><td class=\"total_pages\">%2</td>\n"
" "

---

msgid ""
"\n"
" Unable to request <a href=\"'\n"
"mkurl(ctx.kpac_root _ '/record/' _ ctx.bre_id, { }, kill_params)\n"
"'\">%1</a>.<br/>\n"
" Please see a librarian.\n"
" "

---

msgid ""
"Choose the Lead\n"
" Selection List:"

Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0-rc
importance: Undecided → Medium
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Revision history for this message
Ben Shum (bshum) wrote :

Needs to be rebased to more recent master. Code's drifted a bit and I had enough conflicts while attempting a rebase that I wasn't fully sure what changed and why at each turn.

Changed in evergreen:
status: Triaged → Incomplete
Revision history for this message
Pasi Kallinen (paxed) wrote :

I've updated the branch to master, and squashed the commits into one.

Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m1 → 2.5.0-m2
Revision history for this message
Ben Shum (bshum) wrote :

Setting back to confirmed since paxed did as asked in updating his code for this bug. Probably won't get to finish this review before bumping it to the next 2.5 milestone though.

Changed in evergreen:
status: Incomplete → Confirmed
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
Revision history for this message
Remington Steed (rjs7) wrote :

I fixed a few bugs in Pasi's branch and added them as a new commit. Otherwise, I tested his changes as best as I could by using the interfaces involved, and things seem to work fine. Good work Pasi! Rebased to master and signed off:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/nohtmli18nstrings

working/user/rsteed/nohtmli18nstrings

Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Revision history for this message
Dan Scott (denials) wrote :

I gave Remington's branch a further quick test in TPAC and KPAC and didn't see any obvious remaining problems, then squashed the two commits together as there's no reason to maintain a history with bugs. Pushed to master. Many thanks, Pasi and Remington!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.