Comment 5 for bug 1097915

Oh, one other problem as I dig deeper into the code is that the retrieval mechanism is not efficient. With the Concerto data set, for example, the record display for record 97 goes from an average of about 0.75 seconds (via the TPAC timelog) to 2.65 seconds. Here's an example of the timelog with some additional entries:

At 0.0000: New page
At 0.1265: Initial load
At 0.1519: load_record() began
At 0.1583: past added content stage 1
At 0.1584: past staff saved searches
At 0.1584: Loading results
At 0.1585: Getting search parameters
At 0.1585: Tag circed items?
At 0.1585: Got search parameters
At 0.1592: Firing off the multiclass query
At 0.1728: Returned from the multiclass query
At 0.1728: past related search info
At 0.2546: get_records_and_facets(): about to call multisession
At 0.2564: get_records_and_facets(): about to call unapi.bre via json_query (rec_ids has 1
At 0.2571: get_records_and_facets():almost ready to fetch facets
At 0.4519: get_records_and_facets(): got response content
At 0.4529: get_records_and_facets(): parsed xml
At 0.4531: get_records_and_facets(): end of success handler
At 0.4531: get_records_and_facets():past session wait
At 0.4532: past get_records_and_facets()
At 0.4694: past copy note retrieval call
At 0.4995: past peer bib id retrieval
At 0.4996: get_records_and_facets(): about to call multisession
At 0.5007: get_records_and_facets(): about to call unapi.bre via json_query (rec_ids has 1
At 0.5013: get_records_and_facets():almost ready to fetch facets
At 0.6561: get_records_and_facets(): got response content
At 0.6570: get_records_and_facets(): parsed xml
At 0.6571: get_records_and_facets(): end of success handler
At 0.6572: get_records_and_facets():past session wait
At 0.6573: past peer bib record retrieval
At 0.6697: past copy note retrieval call
At 0.6986: past peer bib id retrieval

... peer bib retrieval / facet retrieval repeats for each copy ...

At 2.5865: get_records_and_facets():past session wait
At 2.5866: past peer bib record retrieval
At 2.5866: past store copy retrieval call
At 2.6113: past get_hold_copy_summary()
At 2.6527: past serials holding stuff
At 2.6528: past expandies
At 2.6528: past added content stage 2

So yes, we definitely have to tighten this up before committing it :/