Comment 11 for bug 1812084

Revision history for this message
Andrew Johnson (anj) wrote :

Michael, I see 2 issues with your patch:

1. It seems to be missing __RTEMS_REVISION__ in RTEMS_VERSION_INT value, so as shown none of the 4.10.x releases would make that version comparison true, although 4.11 releases would. As a result I suspect it would fail in Mike Westfall's environment.

2. You appear to have completely misunderstood the problem with detecting this change at compile-time; I was talking about the fact that both my RTEMS build and Mike's report themselves as being 4.10.2, yet we are on different sides of the structure change. AFAIK there have been no releases or version number bumps on the 4.10 branch since they made the change, so our code can't use the version number to tell the two apart:

tux% git log VERSION
commit 0ae9ee1da48d7deab49e42aa789ba02de8501047 (tag: 4.10.2)
Author: Joel Sherrill <email address hidden>
Date: Tue Dec 13 14:34:19 2011 +0000

    Upgrade to 4.10.2

I haven't looked at it yet but I suspect Heinz' patch will be much more useful; I will take a look at it after my group meeting.