Note that for the previous comment I actually built Base using
make CMD_LDFLAGS=-fsanitize=address CMD_CFLAGS=-fsanitize=address CMD_CXXFLAGS=-fsanitize=address
instead of applying this patch. I'm not sure that we should add options to the CONFIG_SITE files that are intended for developer use and should not be enabled for production builds, so I'm a bit reluctant to make those particular changes.
I can see that we probably should have a collection of settings for developers to use somewhere in Base, which could also include the -fvisibility=hidden flags that I build with. If we do that, this patch is not really necessary since-fsanitize=address could then be added directly to the OP_SYS_CFLAGS and OP_SYS_LDFLAGS make variables instead.
Note that for the previous comment I actually built Base using -fsanitize= address CMD_CFLAGS= -fsanitize= address CMD_CXXFLAGS= -fsanitize= address
make CMD_LDFLAGS=
instead of applying this patch. I'm not sure that we should add options to the CONFIG_SITE files that are intended for developer use and should not be enabled for production builds, so I'm a bit reluctant to make those particular changes.
I can see that we probably should have a collection of settings for developers to use somewhere in Base, which could also include the -fvisibility=hidden flags that I build with. If we do that, this patch is not really necessary since-fsanitize =address could then be added directly to the OP_SYS_CFLAGS and OP_SYS_LDFLAGS make variables instead.
Please discuss...