Comment 127 for bug 1197395

Revision history for this message
In , Colin (colin-redhat-bugs) wrote :

Can you send this patch to systemd-devel? Red Hat Bugzilla is a crappy patch system.

On the actual content of your patch:

* We could also check whether uid != getuid() - i mean we know the code above uses loginuid, so indirecting via lstat() is weird. But I'm OK with the code as is.

* No need to log a message when this happens. We know it will happen, it's "normal", and there are already several log messages emitted for su.