Comment 3 for bug 1257033

Revision history for this message
quequotion (quequotion) wrote :

This bug comes from code in /src/Settings/FilesSettings.vala:

http://bazaar.launchpad.net/~versable/elementary-community/elementary-tweaks/view/head:/src/Settings/FilesSettings.vala

The problem is similar bug 1255665; the code doesn't handle the case of Files not being installed.

I would offer the same three proposals as in bug 1255665, but I think this bug makes a stronger case for options 1 (handle unavailability) or 2 (add a dependency) than 0 (remove the toggles).

In this case the package involved is Elementary-specific. It would be reasonable to make elementary-tweaks depend on pantheon-files in packaging (option 2). However, it would make elementary-tweaks more useful, if it could still be used without Files installed by dynamically loading without File's toggles or with the toggles disabled (option 1).

Since it's likely that one of these bug reports could be made for every software package with settings that elementary-tweaks can manipulate, I think it would be of most benefit to add code to elementary-tweaks to handle the absence of those packages rather than adding dependencies for each of them.