Comment 2 for bug 1222867
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
Hi Brendan,
Thanks for the patch.
Originally, the sales exception module behaved as you suggest [0].
Doing the confirmation here breaks the modularity if we want to use the wizard in another manner. The thing is that I couldn't find anymore why we needed to use it in another manner... but I think that we needed to be able to check if there are exceptions on a sales order even before clicking on the confirm button.
Anyway, this is often a matter of confusion for the users, so I agree with this change and, if the need for the wizard which doesn't confirm comes again, we can introduce an boolean argument for that.
I would like to have other opinions on this change, if someone else see any valid reason not to do that though.
[0] http://